fix crash when closing terminal with exit_cb #1922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1922 +/- ##
==========================================
- Coverage 75.09% 75.07% -0.03%
==========================================
Files 76 76
Lines 125328 125287 -41
==========================================
- Hits 94112 94055 -57
- Misses 31216 31232 +16
Continue to review full report at Codecov.
|
|
Yasuhiro Matsumoto wrote:
When closing terminal with exit_cb options of job, vim crash. Below is
a script to reproduce.
```vim
function! s:exit_cb(job, st)
exe s:buf 'bwipe!'
endfunction
function! s:test()
let s:buf = term_start('ls')
let job = term_getjob(s:buf)
call job_setoptions(job, {'exit_cb': function('s:exit_cb')})
endfunction
call s:test()
I tried writing a test for this, but could not trigger the problem.
Anyway, we can use term_use_loop() to decide whether terminal_loop()
should return.
…--
Q: How does a UNIX Guru pick up a girl?
A: look; grep; which; eval; nice; uname; talk; date;
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When closing terminal with exit_cb options of job, vim crash. Below is a script to reproduce.