Thanks to visit codestin.com
Credit goes to github.com

Skip to content

runtime: Map only visual mode in matchit.vim #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

runtime: Map only visual mode in matchit.vim #1948

wants to merge 1 commit into from

Conversation

@somini
Copy link

@somini somini commented Aug 7, 2017 •
edited
Loading

Instead of admitting to the bug in the documentation, simply map the offending keys in visual mode only.

This is a trivial change.

@somini
runtime: Map only visual mode in matchit.vim
0e814a2 
Instead of admitting to the bug in the documentation, simply map the
offending keys in visual mode only.
@codecov-io
Copy link

Codecov Report

Merging #1948 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1948      +/-   ##
==========================================
+ Coverage   74.77%   74.78%   +0.01%     
==========================================
  Files          77       77              
  Lines      125684   125684              
  Branches    28122    28122              
==========================================
+ Hits        93982    93996      +14     
+ Misses      31698    31684      -14     
  Partials        4        4
Impacted Files Coverage Δ
src/gui.c 45.61% <0%> (-0.06%) ⬇️
src/channel.c 83.84% <0%> (-0.05%) ⬇️
src/evalfunc.c 82.59% <0%> (+0.02%) ⬆️
src/undo.c 81.55% <0%> (+0.06%) ⬆️
src/ex_cmds.c 77.65% <0%> (+0.08%) ⬆️
src/os_unix.c 52.73% <0%> (+0.33%) ⬆️
src/if_xcmdsrv.c 86.11% <0%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a43be...0e814a2. Read the comment docs.

@somini somini mentioned this pull request Aug 7, 2017
Closed
@brammool
Copy link
Contributor

@chrisbra is now the maintainer of this file.

@chrisbra
Copy link
Member

@somini can you please open a PR against https://github.com/chrisbra/matchit/ ? Thanks

chrisbra pushed a commit to chrisbra/matchit that referenced this pull request Sep 27, 2019
@somini @chrisbra
included PR from vim/vim#1948
27f432c 
Most of it was already changed to xmap. The documentation also has long
been changed. So just switch the last few visual mode maps to xmaps.
@chrisbra
Copy link
Member

Nevermind, I have just included your change in chrisbra/matchit@27f432c

@chrisbra chrisbra closed this Sep 27, 2019
@k-takata
Copy link
Member

I think this has been already merged as chrisbra/matchit#14.
Your change is not necessary, I think.

@somini
Copy link
Author

somini commented Sep 27, 2019

I think this has been already merged as chrisbra/matchit#14.
Your change is not necessary, I think.

As mentioned by @chrisbra in chrisbra/matchit@27f432c, this was missing a couple of vmap only.
Thanks you both for getting back to this.

I noticed this was merged to the latest vim version before I was notified on this issue, I had forgot about this particular PR. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@somini @codecov-io @brammool @chrisbra @k-takata