Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix terminal multibyte scraping test on Windows #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix terminal multibyte scraping test on Windows #1975

wants to merge 1 commit into from

Conversation

@micbou
Copy link

@micbou micbou commented Aug 14, 2017

The Test_terminal_scrape_multibyte test fails on Windows with the following errors:

Found errors in Test_terminal_scrape_multibyte():
function RunTheTest[24]..Test_terminal_scrape_multibyte line 21: Expected 'é' but got '├'
function RunTheTest[24]..Test_terminal_scrape_multibyte line 23: Expected 't' but got '⌐'
function RunTheTest[24]..Test_terminal_scrape_multibyte line 25: Expected 'ま' but got 't'
function RunTheTest[24]..Test_terminal_scrape_multibyte line 26: Expected 2 but got 1
function RunTheTest[24]..Test_terminal_scrape_multibyte line 27: Expected 'r' but got 'π'
function RunTheTest[24]..Test_terminal_scrape_multibyte line 28: Expected 's' but got 'ü'

These errors occur because the type command prints l├®ttÒü¥rs (when the code page is 850 which is the default in Western Europe) instead of léttまrs in the terminal . This is fixed by setting the code page to 65001 (UTF-8).

@micbou micbou force-pushed the fix-terminal-multibyte-test-windows branch 2 times, most recently from aea6949 to b40c5bf Compare August 14, 2017 18:11
@codecov-io
Copy link

codecov-io commented Aug 14, 2017 •
edited
Loading

Codecov Report

Merging #1975 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1975      +/-   ##
==========================================
- Coverage   74.69%   74.68%   -0.01%     
==========================================
  Files          77       77              
  Lines      125798   125798              
  Branches    28150    28150              
==========================================
- Hits        93960    93949      -11     
- Misses      31838    31849      +11
Impacted Files Coverage Δ
src/if_xcmdsrv.c 85.37% <0%> (-2.23%) ⬇️
src/gui.c 45.66% <0%> (-0.06%) ⬇️
src/evalfunc.c 82.6% <0%> (-0.03%) ⬇️
src/gui_gtk_x11.c 47.29% <0%> (+0.05%) ⬆️
src/version.c 80.2% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05fbfdc...4ab8e46. Read the comment docs.

@micbou micbou force-pushed the fix-terminal-multibyte-test-windows branch from b40c5bf to 82b39c6 Compare August 14, 2017 20:44
@micbou
Fix terminal multibyte scraping test on Windows
4ab8e46 
The Windows command "type" requires a codepage that supports multibyte
characters to successfully print them.
@micbou micbou force-pushed the fix-terminal-multibyte-test-windows branch from 82b39c6 to 4ab8e46 Compare August 14, 2017 20:48
@micbou
Copy link
Author

micbou commented Aug 14, 2017

Fixed the conflicts.

@brammool brammool closed this in 3678393 Aug 14, 2017
@micbou micbou deleted the fix-terminal-multibyte-test-windows branch August 14, 2017 21:51
adizero pushed a commit to adizero/vim that referenced this pull request May 19, 2018
@brammool @adizero
patch 8.0.0943: MS-Windows: Test_terminal_scrape_multibyte may fail
802f7a8 
Problem:    Test_terminal_scrape_multibyte fails if the codepage is not utf-8.
Solution:   Start "cmd" with the utf-8 codepage. (micbou, closes vim#1975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@micbou @codecov-io