Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix test failure when total time == self time. #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix test failure when total time == self time. #1972

wants to merge 1 commit into from

Conversation

@jamessan
Copy link
Contributor 

From test_profile.vim:
Found errors in Test_profile_file():
function RunTheTest[24]..Test_profile_file line 37: Pattern '^\\s*20\\s\\+\\d\\+\\.\\d\\+\\s\\+\\d\\+\\.\\d\\+\\s\\+call Foo()$' does not match '   20              0.000043   call Foo()'

@jamessan
Fix test failure when total time == self time.
0a81732 
```
From test_profile.vim:
Found errors in Test_profile_file():
function RunTheTest[24]..Test_profile_file line 37: Pattern '^\\s*20\\s\\+\\d\\+\\.\\d\\+\\s\\+\\d\\+\\.\\d\\+\\s\\+call Foo()$' does not match '   20              0.000043   call Foo()'
```
@codecov-io
Copy link

Codecov Report

Merging #1972 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1972      +/-   ##
==========================================
- Coverage   74.71%   74.68%   -0.03%     
==========================================
  Files          77       77              
  Lines      125798   125798              
  Branches    28150    28150              
==========================================
- Hits        93989    93958      -31     
- Misses      31809    31836      +27     
- Partials        0        4       +4
Impacted Files Coverage Δ
src/gui_beval.c 39.93% <0%> (-4.96%) ⬇️
src/window.c 80.86% <0%> (-0.54%) ⬇️
src/if_py_both.h 76.05% <0%> (-0.14%) ⬇️
src/undo.c 81.48% <0%> (-0.07%) ⬇️
src/gui_gtk_x11.c 47.29% <0%> (-0.06%) ⬇️
src/if_xcmdsrv.c 85.18% <0%> (ø) ⬆️
src/evalfunc.c 82.62% <0%> (+0.02%) ⬆️
src/os_unix.c 52.78% <0%> (+0.04%) ⬆️
src/gui.c 45.66% <0%> (+0.05%) ⬆️
src/libvterm/src/screen.c 73.43% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb18a8...0a81732. Read the comment docs.

@brammool brammool closed this in d21b16f Aug 14, 2017
@jamessan jamessan deleted the fix-Test_profile_file branch August 15, 2017 03:31
justinmk added a commit to neovim/neovim that referenced this pull request Oct 29, 2017
@justinmk
vim-patch:8.0.0944
6c43fcc 
Problem:    Test_profile is a little bit flaky.
Solution:   Accept a match when self and total time are the same. (James
            McCoy, closes vim/vim#1972)

vim/vim@d21b16f
adizero pushed a commit to adizero/vim that referenced this pull request May 19, 2018
@brammool @adizero
patch 8.0.0944: test_profile is a little bit flaky
9762c6b 
Problem:    Test_profile is a little bit flaky.
Solution:   Accept a match when self and total time are the same. (James
            McCoy, closes vim#1972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamessan @codecov-io