Use MAXPATHL instead of PATH_MAX for path buffers #1973
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When v:progpath was changed to be absolute, some bare uses of PATH_MAX were added. This should be indirected through MAXPATHL to support both systems that don't define PATH_MAX and to override ones which define it to a relatively small values.
Codecov Report
@@ Coverage Diff @@
## master #1973 +/- ##
==========================================
- Coverage 74.71% 74.68% -0.03%
==========================================
Files 77 77
Lines 125798 125798
Branches 28150 28150
==========================================
- Hits 93989 93955 -34
- Misses 31809 31839 +30
- Partials 0 4 +4
Continue to review full report at Codecov.
|
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
Problem: Using PATH_MAX does not work well on some systems. Solution: use MAXPATHL instead. (James McCoy, closes vim#1973)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When v:progpath was changed to be absolute, some bare uses of PATH_MAX
were added. This should be indirected through MAXPATHL to support both
systems that don't define PATH_MAX and to override ones which define it
to a relatively small values.