Input test for #1940 #2046
Closed
Input test for #1940 #2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2046 +/- ##
==========================================
+ Coverage 74.59% 74.59% +<.01%
==========================================
Files 77 77
Lines 126168 126173 +5
Branches 28243 28244 +1
==========================================
+ Hits 94113 94123 +10
+ Misses 32055 32050 -5
Continue to review full report at Codecov.
|
|
Ozaki Kiichi wrote:
* Add `Test_peek_and_get_char` to test_timers
* Add `test_feedinput` to feed data to `inbuf`
I confirmed this test fails with before 8.0.1020.
https://ci.appveyor.com/project/ichizok/vim/build/428
https://travis-ci.org/ichizok/vim/builds/270689255
Thanks. I thought it was difficult to write a test for this, I'm glad
you found a way.
Can you please write documentation for the test_feedinput() function?
The test should check if the test_feedinput function exists. It is
possible to have the timers feature but not the clientserver feature.
It's safer anyway.
…--
Microsoft is to software what McDonalds is to gourmet cooking
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
|
Sorry, I forgot to add document. I updated commit.
|
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
Problem: No test for what 8.0.1020 fixes. Solution: Add test_feedinput(). Add a test. (Ozaki Kiichi, closes vim#2046)
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 10, 2018
Problem: No test for what 8.0.1020 fixes. Solution: Add test_feedinput(). Add a test. (Ozaki Kiichi, closes vim/vim#2046) vim/vim@5e80de3
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 20, 2018
Problem: No test for what 8.0.1020 fixes. Solution: Add test_feedinput(). Add a test. (Ozaki Kiichi, closes vim/vim#2046) vim/vim@5e80de3
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Aug 22, 2018
Problem: No test for what 8.0.1020 fixes. Solution: Add test_feedinput(). Add a test. (Ozaki Kiichi, closes vim/vim#2046) vim/vim@5e80de3
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Aug 24, 2018
Problem: No test for what 8.0.1020 fixes. Solution: Add test_feedinput(). Add a test. (Ozaki Kiichi, closes vim/vim#2046) vim/vim@5e80de3
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Sep 4, 2018
Problem: No test for what 8.0.1020 fixes. Solution: Add test_feedinput(). Add a test. (Ozaki Kiichi, closes vim/vim#2046) vim/vim@5e80de3
timeyyy
pushed a commit
to timeyyy/neovim
that referenced
this pull request
Sep 23, 2018
Problem: No test for what 8.0.1020 fixes. Solution: Add test_feedinput(). Add a test. (Ozaki Kiichi, closes vim/vim#2046) vim/vim@5e80de3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test_peek_and_get_charto test_timerstest_feedinputto feed data toinbufI confirmed this test fails with before 8.0.1020.
https://ci.appveyor.com/project/ichizok/vim/build/428
https://travis-ci.org/ichizok/vim/builds/270689255