Add tmap for terminal-job mode #2073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattn
reviewed
Sep 9, 2017
src/terminal.c
Outdated
| int c; | ||
|
|
||
| ++no_mapping; | ||
| int prev_State = State; |
mattn
reviewed
Sep 9, 2017
|
|
||
| func Test_terminal_tmap() | ||
| " TODO: Find an equivalent for win32 | ||
| if !has('unix') |
|
jakalope wrote:
This changeset adds terminal-job mode key mapping using commands
`tmap`, `tnoremap`, `tunmap`, etc. Docs are updated and a test is
added.
Thanks for working on this. Can you please put your full name on your
github account?
…--
I AM THANKFUL...
...for a lawn that needs mowing, windows that need cleaning
and gutters that need fixing because it means I have a home.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
|
@brammool Done! |
|
Several of the build configurations are failing because (I think) the systems they're running on don't recognize the I'm open to suggestions on other ways to test this feature. |
|
I'm not sure but can you try it with |
Codecov Report
@@ Coverage Diff @@
## master #2073 +/- ##
==========================================
- Coverage 73.76% 73.75% -0.01%
==========================================
Files 90 90
Lines 130039 130044 +5
Branches 28922 28921 -1
==========================================
- Hits 95928 95920 -8
+ Misses 34111 34104 -7
- Partials 0 20 +20
Continue to review full report at Codecov.
|
|
@mattn That seems to have worked, thanks! |
|
@brammool I don't see any clear way to add tests that would (a) make sense in the context of this PR and (b) improve the test coverage. Please advise. |
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
Problem: Cannot specify mappings for the terminal window.
Solution: Add the :tmap command and associated code. (Jacob Askeland,
closes vim#2073)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds terminal-job mode key mapping using commands
tmap,tnoremap,tunmap, etc. Docs are updated and a test is added.