win32: Make the main item of the installer readonly #2106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to k-takata/vim-win32-installer#3. Current win32 installer can uncheck "Vim executables and runtime files" item, but it is nonsense. Make the item readonly.
Codecov Report
@@ Coverage Diff @@
## master #2106 +/- ##
==========================================
+ Coverage 73.97% 73.98% +<.01%
==========================================
Files 90 90
Lines 131716 131716
Branches 28941 30643 +1702
==========================================
+ Hits 97436 97444 +8
+ Misses 34276 34249 -27
- Partials 4 23 +19
Continue to review full report at Codecov.
|
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
Problem: Can uncheck executables in MS-Windows installer. Solution: Make the choice read-only. (Ken Takata, closes vim#2106)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to k-takata/vim-win32-installer#3.
Current win32 installer can uncheck "Vim executables and runtime files"
item, but it is nonsense. Make the item readonly.