Fix Test_popup_and_window_resize #2186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2186 +/- ##
==========================================
- Coverage 74.21% 74.2% -0.01%
==========================================
Files 90 90
Lines 131978 131977 -1
Branches 30862 28984 -1878
==========================================
- Hits 97942 97933 -9
- Misses 34011 34015 +4
- Partials 25 29 +4
Continue to review full report at Codecov.
|
Sorry, I had misunderstood. When execute vim with absolute/relative path, |
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
Problem: Test_popup_and_window_resize() does not always pass.
Solution: Do not use $VIMPROG, pass the Vim executable in the vimcmd file.
(Ozaki Kiichi, closes vim#2186)
1 task
blueyed
added a commit
to blueyed/neovim
that referenced
this pull request
Aug 12, 2019
Problem: Test_popup_and_window_resize() does not always pass.
Solution: Do not use $VIMPROG, pass the Vim executable in the vimcmd file.
(Ozaki Kiichi, closes vim/vim#2186)
vim/vim@6318205
NOTE: Does not add `GetVimProg()`, but keeps/syncs existing usages of it
in tests (which obviously are all skipped, mostly because of
`!has('terminal')`). Likely to be replaced with `v:progpath` in Vim [1], or
at least that would/should be used with Neovim then probably.
1: vim/vim#4806
blueyed
added a commit
to blueyed/vim
that referenced
this pull request
Aug 12, 2019
This should have been fixed in vim#2186 (v8.0.1179).
blueyed
added a commit
to blueyed/neovim
that referenced
this pull request
Aug 13, 2019
Problem: Test_popup_and_window_resize() does not always pass.
Solution: Do not use $VIMPROG, pass the Vim executable in the vimcmd file.
(Ozaki Kiichi, closes vim/vim#2186)
vim/vim@6318205
vim-patch:8.0.1526: no test using a screen dump yet
Problem: No test using a screen dump yet.
Solution: Add a test for C syntax highlighting. Add helper functions.
vim/vim@da65058
NOTE: uses modified `GetVimProg()` (which is used with skipped tests only
(mostly because of `!has('terminal')`)).
Vim uses a 'vimcmd' file, while Nvim uses `$NVIM_TEST_ARGX` environment
variables.
Ref: vim/vim#4806
blueyed
added a commit
to blueyed/neovim
that referenced
this pull request
Aug 13, 2019
Problem: Test_popup_and_window_resize() does not always pass.
Solution: Do not use $VIMPROG, pass the Vim executable in the vimcmd file.
(Ozaki Kiichi, closes vim/vim#2186)
vim/vim@6318205
vim-patch:8.0.1526: no test using a screen dump yet
Problem: No test using a screen dump yet.
Solution: Add a test for C syntax highlighting. Add helper functions.
vim/vim@da65058
NOTE: uses modified `GetVimProg()` (which is used with skipped tests only
(mostly because of `!has('terminal')`)).
Vim uses a 'vimcmd' file, while Nvim uses `$NVIM_TEST_ARGX` environment
variables.
Ref: vim/vim#4806
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://groups.google.com/forum/#!topic/vim_dev/RskqZ2J-040
vimcmd; set first line to$VIMPROGGetVimProg()to get first line ofvimcmdi.e.$VIMPROGFor example, on Macv:progpathis justvim, so is useless to get vim path.Fix for https://ci.appveyor.com/project/chrisbra/vim-win32-installer/build/503
As for as I investigated, on Windows it needs a wait after sending
<esc>, otherwise vim cannot enter normal mode and receives charactersGi(following<esc>) on insert mode.