Profile log may include invalid byte sequences #2385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d947c51 to
63356cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #2385 +/- ##
==========================================
- Coverage 74.56% 74.5% -0.06%
==========================================
Files 91 91
Lines 132421 132430 +9
Branches 29084 29086 +2
==========================================
- Hits 98734 98671 -63
- Misses 33683 33734 +51
- Partials 4 25 +21
Continue to review full report at Codecov.
|
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
Problem: Profile log may be truncated halfway a character. Solution: Find the start of the character. (Ozaki Kiichi, closes vim#2385)
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Sep 16, 2018
Problem: Profile log may be truncated halfway a character. Solution: Find the start of the character. (Ozaki Kiichi, closes vim/vim#2385) vim/vim@ac112f0
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Mar 9, 2019
Problem: Profile log may be truncated halfway a character. Solution: Find the start of the character. (Ozaki Kiichi, closes vim/vim#2385) vim/vim@ac112f0 nvim does not support "--clean" yet but "-es" should suffice for the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro steps
prof.vim
https://gist.github.com/ichizok/74fc6a2a9d0aa4673d3ea7fabc22908f
vim --clean --cmd 'set enc=utf-8'prof.logwill include UTF-8 invalid byte sequences.Impact
For external application using profile log, this problem can cause errors related to encoding.
e.g. covimerage (python application),
UnicodeDecodeErroroccurs when reading profile logCause
https://github.com/vim/vim/blob/17471e8/src/ex_cmds2.c#L1835
Each lines of script source file are truncated to
IOSIZE - 1(==1024) byte ignoring the boundary of multibyte characters.