Fix directx issues #2440
Closed
Fix directx issues #2440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redraw directly instead of using WM_PAINT.
Some characters like 'y' and 'g' are cut off on some fonts.
Codecov Report
@@ Coverage Diff @@
## master #2440 +/- ##
==========================================
+ Coverage 74.48% 74.51% +0.02%
==========================================
Files 92 92
Lines 132744 132744
Branches 29123 29123
==========================================
+ Hits 98878 98911 +33
+ Misses 33835 33802 -33
Partials 31 31
Continue to review full report at Codecov.
|
The color emoji support requires Windows SDK 8.1 or later. DirectX support could not be enabled after 8.0.1343 without it. Add COLOR_EMOJI option to be able to use older compilers without newer Windows SDK. Also fix indentation. Also update INSTALLpc.txt.
|
I added a fix for https://groups.google.com/d/msg/vim_dev/WxqcR2Z_3hI/zA8g-oF9AgAJ . |
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
…s off
Problem: DirectX scrolling can be slow, vertical positioning is off.
Solution: Make scroll slightly faster when using "scrlines:1". Fix y
position of displayed text. Fix DirectX with non-utf8 encoding.
(Ken Takata, closes vim#2440)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues in the latest directx renderer:
Make scroll slightly faster when
scrlines:1.Fix y-position of displayed text.
I hope that this fixes the issue reported at here: https://groups.google.com/d/msg/vim_dev/2AaZMN1T6K8/mnrR9ZJrBgAJ
Fix directx with non-utf8 encoding.
After 8.0.1343, nothing is displayed when 'enc' is not "utf8" and the directx renderer is selected.
It should have fallen back to the GDI renderer.
Add COLOR_EMOJI option and also update INSTALLpc.txt.
Note that the following issues are not fixed yet:
Reported at https://groups.google.com/d/msg/vim_dev/2AaZMN1T6K8/x4QxC_XbBQAJ .
Reported at https://groups.google.com/d/msg/vim_dev/2AaZMN1T6K8/LRZqOifeBgAJ .