Test backticks expansion: expand('...') and expand('=...')
#2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2479 +/- ##
==========================================
+ Coverage 74.57% 74.57% +<.01%
==========================================
Files 92 92
Lines 132856 132855 -1
Branches 29140 31040 +1900
==========================================
+ Hits 99075 99082 +7
+ Misses 33781 33738 -43
- Partials 0 35 +35
Continue to review full report at Codecov.
|
...) and expand('=...)...') and expand('=...')
|
Dominique wrote:
This PR adds tests for backticks command expansion expand(`...`)
and backticks expression expansion expand(`=...`) which were not
tested according to codecov:
https://codecov.io/gh/vim/vim/src/master/src/misc1.c#L11042
PR also fixes a few typos.
The test of expand() function is currently in testdir/test_normal.vim.
It might be best to move it to test_function.vim, but
I did not do that to keep the diff simpler.
Running Vim to test this seems like a bit of overkill. We can test with
"echo", like in test_system. Do we miss any coverage then/
…--
hundred-and-one symptoms of being an internet addict:
139. You down your lunch in five minutes, at your desk, so you can
spend the rest of the hour surfing the Net.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
Problem: No test for expanding backticks. Solution: Add a test. (Dominique Pelle, closes vim#2479)
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Aug 16, 2018
Problem: No test for expanding backticks. Solution: Add a test. (Dominique Pelle, closes vim/vim#2479) vim/vim@ae6f865
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Aug 18, 2018
Problem: No test for expanding backticks. Solution: Add a test. (Dominique Pelle, closes vim/vim#2479) vim/vim@ae6f865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for backticks command expansion expand('`...`')
and backticks expression expansion expand('`=...`') which were not
tested according to codecov:
https://codecov.io/gh/vim/vim/src/master/src/misc1.c#L11042
PR also fixes a few typos.
The test of expand() function is currently in testdir/test_normal.vim.
It might be best to move it to test_function.vim, but
I did not do that to keep the diff simpler.