Correctly use rb_protect in rubyf #2512
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rb_protect` is a function taking one function with `VALUE (*)(VALUE)` signature, one VALUE argument, one int* argument and returning one VALUE value. At the moment, vim was using it as `void(VALUE (*)(VALUE), int, int*)` which was causing a crash when trying to do `rubyf ...`. `VALUE` argument was sliced into `int` and then promoted back to `VALUE` causing SEGV. Fixes #2511
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Nov 17, 2018
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Nov 18, 2018
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Dec 28, 2018
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Dec 28, 2018
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Dec 31, 2018
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Apr 12, 2019
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Apr 25, 2019
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
May 25, 2019
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jun 8, 2019
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jul 4, 2019
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Aug 23, 2019
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Sep 14, 2019
Problem: Segmentation fault when Ruby throws an exception inside :rubyfile
command.
Solution: Use rb_protect() instead of rb_load_protect(). (ujihisa,
closes vim/vim#2147, greywolf, closes vim/vim#2512, vim/vim#2511)
vim/vim@37badc8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rb_protectis a function taking one function withVALUE (*)(VALUE)signature, one VALUE argument, oneint* argument and returning one VALUE value. At the moment,
vim was using it as
void(VALUE (*)(VALUE), int, int*)whichwas causing a crash when trying to do
rubyf ....VALUEargument was sliced intointand then promoted back toVALUEcausing SEGV.Fixes #2511