fix missing case for displaying varId #7054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This revealed a deeper bug where, if a constant have a varId, it is affected by assertions a weird way and this snippet https://psalm.dev/r/8c26aa0e98 produce an error because |
|
I found these snippets: https://psalm.dev/r/8c26aa0e98<?php
class A
{
public static function analyze(): void
{
$is_path_relative= false;
if (DIRECTORY_SEPARATOR === '/') {
$is_path_relative = true;
}
if ($is_path_relative) {
echo 'a' . DIRECTORY_SEPARATOR;
}
}
} |
Collaborator
Author
|
Well, this is working. I'm not sure I like the fact that I had to call an Analyzer inside the Reconciler though, but I couldn't see a cache of global constants and I'm not sure we're supposed to create one... |
Collaborator
Author
|
Do you have thoughts about that @weirdan ? |
Collaborator
|
Looks good to me. |
This was referenced Dec 30, 2021
Merged
orklah
added a commit
that referenced
this pull request
Jan 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #6933
The message is a little weird because it says
Cannot access value on variable ARRwhen it's a constant, but it's not a big deal.Didn't add test because this is just a wording issue