Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

Conversation

@andyflatt
Copy link

I have updated the example to use these events too.

@andyflatt
Copy link
Author

@josdejong This is the recreation of #773 without the dist changes as requested.

@josdejong
Copy link
Member

Thanks @andyflatt , that's quite some time ago :)

A few remarks:

  • It's expensive (performance wise) to add these event handlers to every individual item. Instead, you could attach these two event handlers to the ItemSet instead (event delegation). It can work exactly like ItemSet._onSelectItem, which uses the method .itemFromTarget(event) to determine which item was tapped exactly. This also would not require any change in any of the item types.
  • Can you please also update the docs with these two new events?

Thanks!

@mojoaxel
Copy link
Member

mojoaxel commented Aug 9, 2016

@andyflatt I would like to merge this. It would be very nice if you would make the changes, pointed out by josdejong. You can just make the changes in your local branch andyflatt:develop and push them. All changes get updated here in the pull request. Thanks!

@Iskander508
Copy link
Contributor

I have reimplemented the hover events via changes in ItemSet and created a different pull-request (Timeline hover (itemover, itemout) events #2099)

@mojoaxel
Copy link
Member

This feature got already implemented by #2099

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants