Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

Small fixes for nested groups #2852

Merged
merged 3 commits into from
Mar 18, 2017
Merged

Small fixes for nested groups #2852

merged 3 commits into from
Mar 18, 2017

Conversation

@BTMorton
Copy link
Contributor

These are fixes implemented by our team to get the desired, dynamic nested group functionality:

  • Allow nested groups to be removed by nulling the nestedGroups content.
  • Don't update the showNested property if nothing has been set in the data object, unless it is undefined.
  • Verify group object exists during onGroupClick

@Tooa Tooa added the Timeline label Mar 11, 2017
@Tooa
Copy link
Contributor

Tooa commented Mar 11, 2017 •
edited
Loading

Thanks for your pull request :) Could you please make it against the develop branch? Does your patch tackle any open issue in our tracker?

@BTMorton BTMorton changed the base branch from master to develop March 13, 2017 10:20
Allow nested groups to be removed by nulling the nestedGroups content.
4126445 
Don't update the showNested property if nothing has been set in the data object, unless it is undefined.
Verify group object exists during `onGroupClick`
@BTMorton BTMorton force-pushed the fixForUpdatingNestedGroups branch from cbfb388 to 4126445 Compare March 13, 2017 10:26
@BTMorton
Copy link
Contributor Author

Apologies, used to merging against master. Should be OK now.

It's not against any open issues that I've seen, it's just a set of fixes that were required for our particular use case. I can open issues with examples of the things this fixes, if it helps?

@bradh
Copy link
Contributor

bradh commented Mar 14, 2017

Seems like another change that would benefit from unit tests

@mojoaxel
Copy link
Member

I can open issues with examples of the things this fixes, if it helps?

@BTMorton Thanks, that would be helpful.

@mojoaxel mojoaxel added this to the Minor Release v4.20 milestone Mar 18, 2017
mojoaxel
mojoaxel approved these changes Mar 18, 2017
View reviewed changes
Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BTMorton BTMorton mentioned this pull request Mar 18, 2017
Closed
@BTMorton
Copy link
Contributor Author

Next included issue: When a group with nested groups is added and updated in the dataset without a showNested property, and the nested groups are currently hidden, triggering the update puts the parent group into un-collapsed mode whilst still not showing the nested groups.

Example can be seen at https://plnkr.co/edit/uobyLYuTGv9zcljkpt0a?p=preview. To reproduce, hide the nested group and click trigger update.

@yotamberk yotamberk merged commit a6a7ee2 into visjs:develop Mar 18, 2017
@yotamberk
Copy link
Member

Thanks @BTMorton ! Looking forward to more PRs from you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mojoaxel mojoaxel mojoaxel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Patch v4.19.1

Development

Successfully merging this pull request may close these issues.

5 participants

@BTMorton @Tooa @bradh @mojoaxel @yotamberk