This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Network: edge-endpoint 'circle' #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anybody please review this! |
Tooa
reviewed
Oct 2, 2016
lib/network/shapes.js
Outdated
|
|
||
| /** | ||
| * Draw an arrow point (no line) | ||
| * Draw an arrow an the end of an line with the given angle. |
There was a problem hiding this comment.
There are two typos: "an the end of an" -> "at the end of a"
|
|
||
| // draw arrow at the end of the line | ||
| ctx.arrow(arrowData.point.x, arrowData.point.y, arrowData.angle, arrowData.length); | ||
| if (arrowData.type && arrowData.type.toLowerCase() === 'circle') { |
There was a problem hiding this comment.
Suggestion: Should we better have something like an enum type holding the different edge types (circle, arrow, ...)? Then the types would be stored in one place rather than distributed through the whole code as strings. However, for now this isn't a problem.
There was a problem hiding this comment.
Good Idea! Let'd do that if more edge types are implemented.
Tooa
approved these changes
Oct 2, 2016
|
@yotamberk Could you please have a look at this!? I consider this a basis to implement further edge-types and not a completed new feature. |
yotamberk
approved these changes
Oct 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to also define an
typeof edge-endpoint (arroworcircle):implements #1993