Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

Conversation

@wimrijnders
Copy link

A round of cleaning up some stuff before making bigger changes.

  • Removed method _determineColumnIndexes(). It's not being used and useless as it is.
  • Moved code for checking consistency value field to its own method.
  • Replace line drawing code with call to _line() - 1 instance
  • Used aliases for certain variables paths when these were obvious - 3 instances.
  • Combined line drawing code for grid style
  • removed/added empty lines
  • some comment cleanup (mostly my own)

ctx.stroke();
from = new Point2d(left - gridLineLen, y);
to = new Point2d(left, y);
this._line(ctx, from, to);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra indent here

@wimrijnders
Copy link
Author

OK fixing it. Don't merge yet.

@yotamberk yotamberk merged commit 25a04fc into visjs:develop Oct 22, 2016
@wimrijnders wimrijnders deleted the PR17 branch October 22, 2016 22:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants