This repository was archived by the owner on Jul 29, 2019. It is now read-only.
#2100 fix and cluster by connection fix #2229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sterByConnection leaving phantom edges.
remove end of file newline on Canvas.js
yotamberk
approved these changes
Oct 25, 2016
mojoaxel
reviewed
Oct 25, 2016
test/DataView.test.js
Outdated
| ]); | ||
| assert.deepEqual(viewUpdates, [ | ||
| ['update', {items: [2], data: [{id: 2, title: 'Item 2 (changed)'}]}] | ||
| ['update', {items: [2], data: [{id: 2, title: 'Item 2 (changed)'}],oldData: [{"group": 2, "id": 2, "title": "Item 2"}]}] |
There was a problem hiding this comment.
This is actually part of #2174. Thx!
mojoaxel
suggested changes
Oct 25, 2016
|
@CapitanMorgan By the way: Thanks very much for this bugfix!! |
|
Fixed spacing, and a few other style items. |
mojoaxel
approved these changes
Oct 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2100, and makes the zoom button on network behave in the more expected fashion. Did this by defining a viewCenter for the canvas, changed the Zoom In/Out buttons function to mirror that of the scroll zoom function. Also fixes an error found with clusterByConnection leaving phantomEdges on the screen. In addition updated a test that fails when you rebuild the library and rerun the tests.
A generic example with the current vis.js combined distributable files
https://jsfiddle.net/p72kewye/35/
A generic example with the proposed changes to the vis.js combined distributable files.
https://jsfiddle.net/xzvxsLjh/1/