-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add support to fixed times drag and drop and support IE #2372
Conversation
|
A couple of more issues (there could be more!) from a cross-browser support perspective:
event.dataTransfer.setData("text/plain", JSON.stringify(item));
var itemData = JSON.parse(event.dataTransfer.getData("text/plain"))
|
|
Thanks @gulench! You are right! I'll add this too the PR |
|
Hey everybody, I dont understand the changes. And If I change or fix the start and end date the item drop anywhere of mouseposition like thanks |
if (isFixedTimes) {
item.start = new Date("2016-12-01T00:00:00.000Z");
item.end = new Date("2016-12-02T00:00:00.000Z");
}Try this and see where the item is placed. |
|
I have no changes mhmm :( there is the code: ... var isFixedTimes = (event.target.innerHTML.split('-')[2] && event.target.innerHTML.split('-')[2].trim() == 'fixed times') thanks |
|
@Clarence344 Let me check it out |
|
@Clarence344 I don't know what's not working for you. It works fine for me. What browser are you using? |
|
Hi,
I use safari and/or Google chrome Browser mhmm
… Am 05.12.2016 um 17:56 schrieb yotamberk ***@***.***>:
@Clarence344 I don't know what's not working for you. It works fine for me. What browser are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@Clarence344 did you pull from this branch and build? |
|
@yotamberk I dont know what you mean? Dynamik Code in github? |
|
This feature will work only if you have this branch with the feature added here in this PR. Once this PR is accepted (if and when), the feature will be available in |
| function handleDrop(event) { | ||
| // return when dropping non-vis items | ||
| try { | ||
| var itemData = JSON.parse(event.dataTransfer.getData("text/plain")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line throws the error Invalid argument in IE10
(Sorry I don't have a IE11 to test.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the whole drop event is different in IE10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I see it now. I'm not sure if I should do this in 2 iterations. It might be worth accepting this PR and I'll submit another PR with IE10 support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, with me.
fixed #2327 and #2370