This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Eliminate possibility of 'window is undefined' during travis test #3406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recurring problem during travis tests is that global variable `window` can get reset while `Network` tests using a mock canvas object are running. This issue has been adressed several times, but it still happens. This PR reduces the possibility of it happening again to a minimum. PR's affected by this issue should be merged with this fix and re-submitted. At time of writing, these are: - visjs#3402 - visjs#3405 - visjs#3399 Chances are it will occur sporadically for other PR's as well. Labelling this `High Priority` because it indrectly affects unrelated PR's.
yotamberk
approved these changes
Sep 2, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
…sjs#3406) A recurring problem during travis tests is that global variable `window` can get reset while `Network` tests using a mock canvas object are running. This issue has been adressed several times, but it still happens. This PR reduces the possibility of it happening again to a minimum. PR's affected by this issue should be merged with this fix and re-submitted. At time of writing, these are: - visjs#3402 - visjs#3405 - visjs#3399 Chances are it will occur sporadically for other PR's as well. Labelling this `High Priority` because it indrectly affects unrelated PR's.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recurring problem during travis tests is that global variable
windowcan get reset whileNetworktests using a mock canvas object are running.This issue has been adressed several times, but it still happens. This PR reduces the possibility of it happening again to a minimum.
PR's affected by this issue should be merged with this fix and re-submitted. At time of writing, these are:
Chances are it will occur sporadically for other PR's as well.
Labelling this
PRIORITYbecause it indrectly affects unrelated PR's.