Vertical Focus - Bugfix on Final Vertical Scroll Position #3508
Conversation
| setFinalVerticalPosition(); | ||
|
|
||
| // Let the redraw settle and finalize the position. | ||
| setTimeout(setFinalVerticalPosition, 100); |
There was a problem hiding this comment.
Try requestFrameAnimation instead of setTimeout
There was a problem hiding this comment.
I don't think that will accomplish what I'm trying to do here. The core issue that I noticed is the timeline resizes groups as you scroll horizontally, and if that resize happens just after the vertical scroll finishes then the "final" position the user sees is not the item that they asked to have focused. I don't have an event I can hook into for that at the moment, so the best I've got is a small delay after the vertical scroll has finished to essentially do a "double check". requestAnimationFrame would likely call this too soon, which is why I chose setTimeout. If you have a suggestion for an event or something else I could check that would be more reliable I'll gladly use that.
There was a problem hiding this comment.
mmm Not really. I'll approve it for now. I'l think about it more though.
There was a problem hiding this comment.
I'm wanting to try and do some tracing of the various events that are being emitted so I can understand where and when the recalculations come from post-focus. If I find something l'll let you know.
Bugfix for #3504.
@yotamberk Sorry for the quick second pull request on this. I realized once I put everything back together that I made an error with where the
setTimeoutwas located for ensuring the final scroll position. It works fine in the example, but a more complex timeline with a heavier redraw (like the one I have in my own project) needs to have this in the proper location.