replacing all ES6 imports with CJS require calls #3063
Conversation
resolves visjs#2934 used the following regex to apply the changes in lib: s/import\s+(\w+)\s+from\s+(.*);\s*$/var $1 = require($2).default;/ s/import\s+(\w+)\s+from\s+(.*)\s*$/var $1 = require($2).default;/
lib/network/Images.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| import CachedImage from './CachedImage'; | |||
| var CachedImage = require('./CachedImage').default; | |||
There was a problem hiding this comment.
CachedImage is an ES6 module because it is exported with ES6 export syntax.
Images is also an ES6 module. export default Images; at the end.
So it's again mixing styles because it's importing CachedImage with a cjs syntax inside an ES6 module.
There was a problem hiding this comment.
Since you used a regex to search and replace, I suppose it must have happened in other places.
There was a problem hiding this comment.
i'll check for these occurrences. For mixed imports I'll modify the export to CJS style, for unmixed imports i'll revert to ES6 exports.
Edit: ignore that first part, no coffee yet this morning.
|
Thanks for the PR but this has also changed imports where it shouldn't. |
|
😞 |
resolves #2934
used the following regex patterns to apply the changes in
lib:s/import\s+(\w+)\s+from\s+(.*);\s*$/var $1 = require($2).default;/s/import\s+(\w+)\s+from\s+(.*)\s*$/var $1 = require($2).default;/There weren't too many instances to patch, 91 total. ran build and tests, no issues on either end.
Open to suggestions if there are any. This PR is really designed as a quick band-aid patch to allow vis module imports from within webpack.