This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Consolidate code for determining the pixel ratio #3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh
previously approved these changes
May 22, 2017
|
@bradh Yeah, I agree. Some more thought could be put in combining more related common functionality. E.g. in all cases but one, the pixel ratio is used to set the transform in a context - which invariably comes from the But current is a quick fix to remove the hurt in my eyes. Any more works requires non-zero brainpower. |
…as.pixelRatio is used. - consolidated ctx.transform() calls in Canvas - Added/edited commenting (also TODO's) - Added Canvas.getContext()
|
You can review this PR now BTW. I've done enough refactoring for pixel ratio. |
yotamberk
approved these changes
Jun 13, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Consolidate code for determining the pixel ratio * - Removed local param 'pixerRatio' from CanvasRenderer. Now only canvas.pixelRatio is used. - consolidated ctx.transform() calls in Canvas - Added/edited commenting (also TODO's) - Added Canvas.getContext()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactoring of the 'can not unsee' variety.
Consolidate code for determining the pixel ratio in
CanvasRenderer, with the same code present inCanvas.