This repository was archived by the owner on Jul 29, 2019. It is now read-only.
lint shared #3309
Merged
lint shared #3309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wimrijnders
suggested changes
Jul 29, 2017
lib/shared/ColorPicker.js
Outdated
| // bound by | ||
| this.updateCallback = () => {}; | ||
| this.closeCallback = () => {}; | ||
| this.updateCallback = () => {} |
There was a problem hiding this comment.
I'm not too happy with these two; they're assignments of functions and usually these would be terminated with a ;. This looks like an omission in eslint.
wimrijnders
reviewed
Jul 31, 2017
|
No. It was my IDE that suggested those changes that you wanted rolled back, not eslint. |
|
Ah, ok. But I'll assume you also did the tests with |
wimrijnders
approved these changes
Aug 1, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* lint shared
* Re-introduce semi-colons to () => {} variables in ColorPicker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @wimrijnders @mojoaxel