This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Addresses TODOs in Queue unit test by adding unit tests for setOption… #3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wimrijnders
approved these changes
Aug 27, 2017
There was a problem hiding this comment.
This has got to be the cleanest set of unit tests I've ever seen. They also all pass so I gather that the TODO's were for adding the unit tests only.
One minor niggle: I prefer to set the label for it() to something that reads like a sentence starting with 'it', e.g.: it('does something interesting'). It's a minor point and I'll let it pass here because the tests already present don't adhere to that either.
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and destroy
R: @yotamberk