Storing ghost bit as array instead of storing it in cell type #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the information that a cell is a ghost cell was stored directly in the type (as 8th bit). This is different to vtk-m where ghost bit information of a grid is stored in a data field. To make sure we can create an array handle of the type list of a cell without having to copy it, while still storing the correct cell type, cell::GHOST_BIT, cell::CONVEX_BIT and cell::TYPE_MASK have been removed from celltypes.h and any other files containing it. Instead an array "ghost" has been added to the Indexed class. From now on, we also have to assume that the given data is convex, as convexity information has previously also been stored in the type (as 7th bit).