WIP: Perf and other cleanup #681
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atlas0fd00m
reviewed
May 24, 2025
| logger.warning('Invalid Section-Headers Size: should be: %d retrieved: %d', secslen, len(secbytes)) | ||
|
|
||
| vstruct.VArray(elems=secs).vsParse(secbytes, fast=True) | ||
| secs = vstruct.VArray() |
There was a problem hiding this comment.
if this is the direction, be sure to clean up the creation of secs above. if you don't need it kill sec as well
atlas0fd00m
reviewed
May 24, 2025
|
|
||
| vstruct.VArray(elems=syms).vsParse(symtab, fast=True) | ||
| syms = vstruct.VArray() | ||
| [syms.vsAddElement(self._cls_symbol(bigend=self.bigend)) for i in range(count)] |
There was a problem hiding this comment.
you no longer use sym, defined above as self._cls_symbol(bigend=self.bigend)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still very much WIP, but this is some fallout from me testing out pyinstrument.
But some rough numbers so far:
So roughly 5-7% decrease in runtime across the board. Gonna be on the hunt for more.