-
Notifications
You must be signed in to change notification settings - Fork 38
Quick fix for support latest Vulkan Headers #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
root-stas
wants to merge
2
commits into
vkmark:master
Choose a base branch
from
root-stas:next
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./src/vulkan_state.cpp: In member function 'void VulkanState::create_instance(VulkanWSI&)':
../src/vulkan_state.cpp:203:32: warning: 'vk::DebugUtilsMessengerCreateInfoEXT& vk::DebugUtilsMessengerCreateInfoEXT::setPfnUserCallback(PFN_vkDebugUtilsMessengerCallbackEXT)' is deprecated: This setter is deprecated. Use the one taking a function pointer type from the vk-namespace instead. [-Wdeprecated-declarations]
195 | auto const debug_create_info = vk::DebugUtilsMessengerCreateInfoEXT{}
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
196 | .setMessageSeverity(vk::DebugUtilsMessageSeverityFlagBitsEXT::eVerbose |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
197 | vk::DebugUtilsMessageSeverityFlagBitsEXT::eInfo |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
198 | vk::DebugUtilsMessageSeverityFlagBitsEXT::eWarning |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
199 | vk::DebugUtilsMessageSeverityFlagBitsEXT::eError)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
200 | .setMessageType(vk::DebugUtilsMessageTypeFlagBitsEXT::eGeneral |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
201 | vk::DebugUtilsMessageTypeFlagBitsEXT::eValidation |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
202 | vk::DebugUtilsMessageTypeFlagBitsEXT::ePerformance)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
203 | .setPfnUserCallback(debug_callback);
| ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
In file included from /home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan.hpp:9625,
from ../src/pch/cpp_pch.h:1:
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_structs.hpp:32331:40: note: declared here
32331 | DebugUtilsMessengerCreateInfoEXT & setPfnUserCallback( PFN_vkDebugUtilsMessengerCallbackEXT pfnUserCallback_ ) VULKAN_HPP_NOEXCEPT
| ^~~~~~~~~~~~~~~~~~
../src/vulkan_state.cpp:207:52: error: no matching function for call to 'vk::Instance::createDebugUtilsMessengerEXT(const vk::DebugUtilsMessengerCreateInfoEXT&, std::nullptr_t, const {anonymous}::DebugUtilsDispatcher&) const'
207 | instance().createDebugUtilsMessengerEXT(debug_create_info, nullptr, dud),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan.hpp:9624:
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:21526:33: note: candidate: 'template<class Dispatch, typename std::enable_if<vk::detail::isDispatchLoader<Type>::value, bool>::type <anonymous> > vk::Result vk::Instance::createDebugUtilsMessengerEXT(const vk::DebugUtilsMessengerCreateInfoEXT*, const vk::AllocationCallbacks*, vk::DebugUtilsMessengerEXT*, const Dispatch&) const'
21526 | VULKAN_HPP_NODISCARD Result createDebugUtilsMessengerEXT( const DebugUtilsMessengerCreateInfoEXT * pCreateInfo,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:21526:33: note: template argument deduction/substitution failed:
../src/vulkan_state.cpp:207:81: note: cannot convert 'dud' (type 'const {anonymous}::DebugUtilsDispatcher') to type 'vk::DebugUtilsMessengerEXT*'
207 | instance().createDebugUtilsMessengerEXT(debug_create_info, nullptr, dud),
| ^~~
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:21535:7: note: candidate: 'template<class Dispatch, typename std::enable_if<vk::detail::isDispatchLoader<Type>::value, bool>::type <anonymous> > vk::ResultValueType<vk::DebugUtilsMessengerEXT>::type vk::Instance::createDebugUtilsMessengerEXT(const vk::DebugUtilsMessengerCreateInfoEXT&, vk::Optional<const vk::AllocationCallbacks>, const Dispatch&) const'
21535 | createDebugUtilsMessengerEXT( const DebugUtilsMessengerCreateInfoEXT & createInfo,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:21535:7: note: template argument deduction/substitution failed:
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:21533:152: error: no type named 'type' in 'struct std::enable_if<false, bool>'
21533 | template <typename Dispatch = VULKAN_HPP_DEFAULT_DISPATCHER_TYPE, typename std::enable_if<detail::isDispatchLoader<Dispatch>::value, bool>::type = true>
| ^~~~
../src/vulkan_state.cpp:208:95: error: no matching function for call to 'ManagedResource<vk::DebugUtilsMessengerEXT>::ManagedResource(<brace-enclosed initializer list>)'
208 | [this, dud] (auto& d) {instance().destroyDebugUtilsMessengerEXT(d, nullptr, dud);}};
| ^
In file included from ../src/vulkan_state.h:28,
from ../src/vulkan_state.cpp:23:
../src/managed_resource.h:40:5: note: candidate: 'ManagedResource<T>::ManagedResource(ManagedResource<T>&&) [with T = vk::DebugUtilsMessengerEXT]'
40 | ManagedResource(ManagedResource&& rhs)
| ^~~~~~~~~~~~~~~
../src/managed_resource.h:40:5: note: candidate expects 1 argument, 2 provided
../src/managed_resource.h:34:5: note: candidate: 'ManagedResource<T>::ManagedResource(T&&, Destructor&&) [with T = vk::DebugUtilsMessengerEXT; Destructor = std::function<void(vk::DebugUtilsMessengerEXT&)>]'
34 | ManagedResource(T&& raw, Destructor&& destructor)
| ^~~~~~~~~~~~~~~
../src/managed_resource.h:34:5: note: conversion of argument 1 would be ill-formed:
../src/managed_resource.h:32:5: note: candidate: 'constexpr ManagedResource<T>::ManagedResource() [with T = vk::DebugUtilsMessengerEXT]'
32 | ManagedResource() = default;
| ^~~~~~~~~~~~~~~
../src/managed_resource.h:32:5: note: candidate expects 0 arguments, 2 provided
ninja: build stopped: subcommand failed.
./src/ws/kms_window_system.cpp: In function 'std::vector<long unsigned int> {anonymous}::vk_get_supported_mods_for_format(VulkanState&, vk::Format)':
../src/ws/kms_window_system.cpp:489:53: error: no matching function for call to 'vk::PhysicalDevice::getFormatProperties2KHR(vk::Format&, vk::FormatProperties2*, const {anonymous}::GetFormatProperties2Dispatcher&) const'
489 | vulkan.physical_device().getFormatProperties2KHR(format, &props, dispatch);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan.hpp:9624,
from ../src/ws/kms_window_system.h:29,
from ../src/ws/kms_window_system.cpp:23:
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:19854:10: note: candidate: 'template<class Dispatch, typename std::enable_if<vk::detail::isDispatchLoader<Type>::value, bool>::type <anonymous> > void vk::PhysicalDevice::getFormatProperties2KHR(vk::Format, vk::FormatProperties2*, const Dispatch&) const'
19854 | void getFormatProperties2KHR( Format format,
| ^~~~~~~~~~~~~~~~~~~~~~~
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:19854:10: note: template argument deduction/substitution failed:
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:19853:152: error: no type named 'type' in 'struct std::enable_if<false, bool>'
19853 | template <typename Dispatch = VULKAN_HPP_DEFAULT_DISPATCHER_TYPE, typename std::enable_if<detail::isDispatchLoader<Dispatch>::value, bool>::type = true>
| ^~~~
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:19861:44: note: candidate: 'template<class Dispatch, typename std::enable_if<vk::detail::isDispatchLoader<Type>::value, bool>::type <anonymous> > vk::FormatProperties2 vk::PhysicalDevice::getFormatProperties2KHR(vk::Format, const Dispatch&) const'
19861 | VULKAN_HPP_NODISCARD FormatProperties2 getFormatProperties2KHR( Format format,
| ^~~~~~~~~~~~~~~~~~~~~~~
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:19861:44: note: candidate expects 2 arguments, 3 provided
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:19871:26: note: candidate: 'template<class X, class Y, class ... Z, class Dispatch, typename std::enable_if<vk::detail::isDispatchLoader<Dispatch>::value, bool>::type <anonymous> > vk::StructureChain<X, Y, Z ...> vk::PhysicalDevice::getFormatProperties2KHR(vk::Format, const Dispatch&) const'
19871 | getFormatProperties2KHR( Format format, Dispatch const & d VULKAN_HPP_DEFAULT_DISPATCHER_ASSIGNMENT ) const VULKAN_HPP_NOEXCEPT;
| ^~~~~~~~~~~~~~~~~~~~~~~
/home/root-stas/distribution/build.ROCKNIX-H700.aarch64/toolchain/aarch64-rocknix-linux-gnu/sysroot/usr/include/vulkan/vulkan_handles.hpp:19871:26: note: candidate expects 2 arguments, 3 provided
ninja: build stopped: subcommand failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve compilations error, but not good way, so if you have a time to make it better, please fix it.
Commit contains compilation errors.
Thanks