math.big: add shrink zeros to karatsuba and toom-cook #24937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: V_0.6-23406 |
spytheman
approved these changes
Jul 20, 2025
Member
spytheman
left a comment
There was a problem hiding this comment.
Thank you 🙇🏻 .
Excellent work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next stage of fighting with zeros in Karatsuba and Toom-Cook.
Zeros can be not only at the end, but also in the middle of the array.
Before the limb arrays are passed further down the computation stack, they must be (!) normalized.
The test will not pass now on
masterwithout the patch and the values were obtained programmatically.