Thanks to visit codestin.com
Credit goes to github.com

Skip to content

math.bits: add asm implementations for some 64 bit ops #25020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Aug 11, 2025
Merged

math.bits: add asm implementations for some 64 bit ops #25020

merged 19 commits into from
Aug 11, 2025

Conversation

@kbkpbot
Copy link
Contributor

@kbkpbot kbkpbot commented Aug 1, 2025 •
edited by huly-for-github bot
Loading

Add asm implementation for mul_64, div_64; add new function mul_add_64.

@huly-for-github
Copy link

Connected to Huly®: V_0.6-23537

@kbkpbot kbkpbot mentioned this pull request Aug 7, 2025
Merged
@tankf33der
Copy link
Contributor

  1. Verified that the performance is the same, it didn't get worse.
  2. Added mul_add_64() to my test suite for testing the math.bits module. Passed.

@kbkpbot
Copy link
Contributor Author

kbkpbot commented Aug 9, 2025

The [V Apps and Modules / v-apps-compile (ubuntu-latest) (pull_request)](https://github.com/vlang/v/actions/runs/16847678395/job/47729553985?pr=25020)Failing after 9m is related to a vtcc bug , in issue #25079

@spytheman
Copy link
Member

The other PR is merged now.
@kbkpbot please rebase this one over current master, so that the CI can check it again.

@spytheman spytheman changed the title math.bits: add asm imp for some 64 ops math.bits: add asm implementations for some 64 bit ops Aug 11, 2025
spytheman
spytheman approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 3507477 into vlang:master Aug 11, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spytheman spytheman spytheman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kbkpbot @tankf33der @spytheman