Always create DataUpload configmap in restore namespace #8621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Seago <[email protected]>
680830c to
d090d0a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8621 +/- ##
=======================================
Coverage 59.19% 59.19%
=======================================
Files 370 370
Lines 39812 39812
=======================================
Hits 23566 23566
Misses 14746 14746
Partials 1500 1500 ☔ View full report in Codecov by Sentry. |
shubham-pampattiwar
approved these changes
Jan 16, 2025
Lyndon-Li
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
In the DataUpload RIA, always create the ConfigMap in the Restore (velero) ns rather than the NS that the DataUpload was created in.
In most cases these are the same, but they won't be if the backup was done in a cluster with velero installed in namespace1 and the restore is being done with velero installed in namespace2. In this case, we need the configmap created in the namespace that velero is currently running in.
Does your change fix a particular issue?
Fixes #8617
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.