Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(a11y): icon button-black focus outline does not meet 3:1 contrast minimum in dark theme #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andyfeds merged 1 commit into from
Mar 28, 2024
Merged

fix(a11y): icon button-black focus outline does not meet 3:1 contrast minimum in dark theme #297

andyfeds merged 1 commit into from
Mar 28, 2024

Conversation

@andyfeds
Copy link
Contributor

@andyfeds andyfeds commented Mar 27, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-1604

What is the new behavior?

The focus outline colour defaults to the webkit-focus-ring-color in dark theme on windows chrome.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(a11y): icon button-black focus outline does not meet 3:1 contrast…
9dfb245 
… minimum in dark theme

- CDE-1604

Authored-by: Andrea Fernandes <[email protected]>
@andyfeds andyfeds self-assigned this Mar 27, 2024
@github-actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

👋 @andyfeds,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@andyfeds andyfeds requested review from a team and sandeepkulki March 27, 2024 10:05
sandeepkulki
sandeepkulki approved these changes Mar 27, 2024
View reviewed changes
Copy link

@sandeepkulki sandeepkulki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non breaking change;

@andyfeds andyfeds merged commit ef26b12 into vmware-clarity:main Mar 28, 2024
@github-actions
Copy link

github-actions bot commented Apr 1, 2024

🎉 This PR is included in version 6.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Apr 17, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sandeepkulki sandeepkulki sandeepkulki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andyfeds andyfeds

Labels

cla-not-required released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andyfeds @sandeepkulki @vmwclabot