Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(tokens): add/update color tokens #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dtsanevmw merged 1 commit into from
May 28, 2024
Merged

feat(tokens): add/update color tokens #310

dtsanevmw merged 1 commit into from
May 28, 2024

Conversation

@dtsanevmw
Copy link
Contributor

@dtsanevmw dtsanevmw commented May 28, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2038, CDE-1923

What is the new behavior?

Updates values of interactions tokens to meet requirements and add two new tokens for selected hover/active state.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dtsanevmw dtsanevmw self-assigned this May 28, 2024
@github-actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/add_new_tokens branch 3 times, most recently from e86aeed to 207917f Compare May 28, 2024 11:26
valentin-mladenov
valentin-mladenov reviewed May 28, 2024
View reviewed changes
@dtsanevmw dtsanevmw force-pushed the dtsanevmw/add_new_tokens branch from 207917f to 19e6b52 Compare May 28, 2024 12:07
valentin-mladenov
valentin-mladenov approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtsanevmw dtsanevmw merged commit add30be into main May 28, 2024
@github-actions
Copy link

github-actions bot commented May 28, 2024

🎉 This PR is included in version 6.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dtsanevmw dtsanevmw mentioned this pull request May 30, 2024
Merged
dtsanevmw added a commit that referenced this pull request May 30, 2024
@dtsanevmw
fix: use construction value for new selected tokens (#311)
f274849 
Edit the values of the new tokens to use `construction` instead of
`blue` #310
@github-actions
Copy link

github-actions bot commented Jun 12, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@valentin-mladenov valentin-mladenov valentin-mladenov approved these changes

Assignees

@dtsanevmw dtsanevmw

Labels

cla-not-required released type:feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dtsanevmw @valentin-mladenov @vmwclabot