Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(token): update color alias tokens #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentin-mladenov merged 8 commits into from
Oct 25, 2024
Merged

fix(token): update color alias tokens #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f0f397e
fix(token): viz border light theme
valentin-mladenov Oct 23, 2024
ceb6bfa
Update index.performance.ts
valentin-mladenov Oct 23, 2024
0685d46
update viz severity and add hero header background color
valentin-mladenov Oct 24, 2024
b643a2f
add hero-header-background darck theme
valentin-mladenov Oct 24, 2024
ac56a78
revert hero header token
valentin-mladenov Oct 24, 2024
ad923c9
revert hero header token dark theme
valentin-mladenov Oct 24, 2024
c754871
update alias tokens
valentin-mladenov Oct 25, 2024
7e7be5a
update alias tokens dark theme
valentin-mladenov Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions projects/core/build/tokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,16 @@ const aliases = {
},
disabled: token(color.white),
highlight: token(color.blue[700]),
shade: {
value: token(color.coolGray[50]),
hover: token(color.construction[100]),
active: token(color.blue[75]),
selected: {
value: token(color.white),
hover: token(color.construction[100]),
active: token(color.construction[200]),
},
},
},
color: {
value: token(color.construction[700]),
Expand Down Expand Up @@ -598,20 +608,6 @@ const aliases = {
hover: token(color.construction[600]),
click: token(color.construction[800]),
},
vertical: {
navigation: {
background: {
color: token(color.coolGray[50]),
hover: token(color.construction[100]),
active: token(color.blue[75]),
selected: {
value: token(color.white),
hover: token(color.construction[100]),
active: token(color.construction[200]),
},
},
},
},
},
app: {
background: token(color.construction[25]),
Expand All @@ -625,7 +621,7 @@ const aliases = {
value: token(color.white),
tint: token(color.construction[50]),
shade: token(color.construction[100]),
dark: token(color.construction[200]),
dark: token(color.coolGray[50]),
inverse: {
value: token(color.construction[600]),
tint: token(color.construction[800]),
Expand Down Expand Up @@ -727,7 +723,7 @@ const aliases = {
},
},
viz: {
border: token(color.coolGray[50]),
border: token(color.construction[1100]),
general: {
1: {
blue: token(color.blue[600]),
Expand Down Expand Up @@ -785,7 +781,7 @@ const aliases = {
value: token(color.yellow[700]),
light: token(color.yellow[400]),
},
immediate: token(color.tangerine[700]),
immediate: token(color.tangerine[400]),
critical: token(color.red[700]),
},
sequential: {
Expand Down
2 changes: 1 addition & 1 deletion projects/core/src/index.performance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { testBundleSize } from 'web-test-runner-performance/browser.js';

describe('performance', () => {
it(`should meet maximum individual css bundle size limits`, async () => {
expect((await testBundleSize('@cds/core/global.min.css')).kb).toBeLessThan(9.5);
expect((await testBundleSize('@cds/core/global.min.css')).kb).toBeLessThan(10);
expect((await testBundleSize('@cds/core/styles/theme.dark.min.css')).kb).toBeLessThan(1.29);
expect((await testBundleSize('@cds/core/list/list.min.css')).kb).toBeLessThan(0.4);

Expand Down
14 changes: 7 additions & 7 deletions projects/core/src/styles/theme.dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
--cds-alias-object-container-background: #{$cds-global-color-construction-900};
--cds-alias-object-container-background-tint: #{$cds-global-color-construction-1000};
--cds-alias-object-container-background-shade: #{$cds-global-color-construction-800};
--cds-alias-object-container-background-dark: #{$cds-global-color-construction-700};
--cds-alias-object-container-background-dark: #{$cds-global-color-construction-1100};
--cds-alias-object-container-background-inverse: #{$cds-global-color-construction-200};
--cds-alias-object-container-background-inverse-tint: #{$cds-global-color-construction-100};
--cds-alias-object-container-background-inverse-shade: #{$cds-global-color-construction-300};
Expand All @@ -78,12 +78,12 @@
--cds-alias-object-interaction-background-selected-hover: #{$cds-global-color-construction-700};
--cds-alias-object-interaction-background-disabled: #{$cds-global-color-construction-700};
--cds-alias-object-interaction-background-highlight: #{$cds-global-color-blue-400};
--cds-alias-object-interaction-vertical-navigation-background-color: #{$cds-global-color-construction-1100};
--cds-alias-object-interaction-vertical-navigation-background-hover: #{$cds-global-color-construction-600};
--cds-alias-object-interaction-vertical-navigation-background-active: #{$cds-global-color-construction-800};
--cds-alias-object-interaction-vertical-navigation-background-selected: #{$cds-global-color-construction-700};
--cds-alias-object-interaction-vertical-navigation-background-selected-hover: #{$cds-global-color-construction-800};
--cds-alias-object-interaction-vertical-navigation-background-selected-active: #{$cds-global-color-construction-600};
--cds-alias-object-interaction-background-shade: #{$cds-global-color-construction-1100};
--cds-alias-object-interaction-background-shade-hover: #{$cds-global-color-construction-600};
--cds-alias-object-interaction-background-shade-active: #{$cds-global-color-construction-800};
--cds-alias-object-interaction-background-shade-selected: #{$cds-global-color-construction-700};
--cds-alias-object-interaction-background-shade-selected-hover: #{$cds-global-color-construction-800};
--cds-alias-object-interaction-background-shade-selected-active: #{$cds-global-color-construction-600};
--cds-alias-object-interaction-border-color: #{$cds-global-color-construction-300};
--cds-alias-object-interaction-info-hover: #{$cds-global-color-blue-300};
--cds-alias-object-interaction-info-click: #{$cds-global-color-blue-500};
Expand Down