Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add free space color tokens for charts #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aishu-nair merged 6 commits into from
Dec 12, 2024
Merged

feat: add free space color tokens for charts #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7d925b
feat: add two new tokens for charts documention
aishu-nair Dec 3, 2024
0fefb14
lint: fix
aishu-nair Dec 3, 2024
9884328
fix: severity-free-space-fill color update
aishu-nair Dec 3, 2024
4281363
fix: remove token dark theme in border since it is same as in light t…
aishu-nair Dec 11, 2024
5d839cc
Merge branch 'main' into aishu-nair/cde-2457-add-token-charts
aishu-nair Dec 11, 2024
a49ada7
fix: update theme.dark.min.css bundle size in index.performance.ts
aishu-nair Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/core/build/tokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,10 @@ const aliases = {
},
immediate: token(color.tangerine[400]),
critical: token(color.red[700]),
freeSpace: {
fill: token(color.construction[100]),
border: token(color.construction[400]),
},
},
sequential: {
blue: {
Expand Down
2 changes: 1 addition & 1 deletion projects/core/src/index.performance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { testBundleSize } from 'web-test-runner-performance/browser.js';
describe('performance', () => {
it(`should meet maximum individual css bundle size limits`, async () => {
expect((await testBundleSize('@cds/core/global.min.css')).kb).toBeLessThan(10);
expect((await testBundleSize('@cds/core/styles/theme.dark.min.css')).kb).toBeLessThan(1.3);
expect((await testBundleSize('@cds/core/styles/theme.dark.min.css')).kb).toBeLessThan(1.307);
expect((await testBundleSize('@cds/core/list/list.min.css')).kb).toBeLessThan(0.4);

// contained in @cds/core/global.min.css
Expand Down
1 change: 1 addition & 0 deletions projects/core/src/styles/theme.dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@
--cds-alias-viz-severity-warning-light: #{$cds-global-color-yellow-300};
--cds-alias-viz-severity-immediate: #{$cds-global-color-tangerine-400};
--cds-alias-viz-severity-critical: #{$cds-global-color-red-700};
--cds-alias-viz-severity-free-space-fill: #{$cds-global-color-construction-800};
--cds-alias-viz-sequential-blue-50: #{$cds-global-color-blue-1000};
--cds-alias-viz-sequential-blue-100: #{$cds-global-color-blue-900};
--cds-alias-viz-sequential-blue-200: #{$cds-global-color-blue-800};
Expand Down
Loading