Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MarkdownEditor : Copy local GIF to clipboard without frame loss #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
Merged

MarkdownEditor : Copy local GIF to clipboard without frame loss #2654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99cbb2a
ClipboardUtils : allow local file to clipboard
SugarWong97 Sep 16, 2025
af9c34d
MarkdownEditor : Copy local GIF to clipboard without frame loss
SugarWong97 Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/utils/clipboardutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

#include "utils.h"
#include "pathutils.h"
#include "fileutils.h"

using namespace vnotex;

Expand Down Expand Up @@ -186,6 +187,7 @@ void ClipboardUtils::setImageToClipboard(QClipboard *p_clipboard,
#endif
}


void ClipboardUtils::setImageLoop(QClipboard *p_clipboard,
const QImage &p_image,
QClipboard::Mode p_mode)
Expand Down Expand Up @@ -220,3 +222,16 @@ std::unique_ptr<QMimeData> ClipboardUtils::linkMimeData(const QString &p_link)
data->setText(text);
return data;
}

void ClipboardUtils::setLocalFileToClipboard(QClipboard *p_clipboard,
const QString &p_filePath,
QClipboard::Mode p_mode)
{
// Check if the file exists
if (!FileUtils::existsCaseInsensitive(p_filePath)) {
qWarning() << "ClipboardUtils::setLocalFileToClipboard: file does not exist:" << p_filePath;
return;
}

setMimeDataToClipboard(p_clipboard, linkMimeData(p_filePath).release(), p_mode);
}
5 changes: 5 additions & 0 deletions src/utils/clipboardutils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ namespace vnotex
const QImage &p_image,
QClipboard::Mode p_mode = QClipboard::Clipboard);

// Set a local file to clipboard.
static void setLocalFileToClipboard(QClipboard *p_clipboard,
const QString &p_filePath,
QClipboard::Mode p_mode = QClipboard::Clipboard);

private:
static bool mimeDataEquals(const QMimeData *p_a, const QMimeData *p_b);

Expand Down
6 changes: 6 additions & 0 deletions src/widgets/editors/markdowneditor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1677,6 +1677,12 @@ bool MarkdownEditor::prependImageMenu(QMenu *p_menu, QAction *p_before, int p_cu
auto clipboard = QApplication::clipboard();
clipboard->clear();

// Copy local GIF to clipboard to ensure no frame loss
if (imgPath.endsWith(QStringLiteral(".gif"), Qt::CaseInsensitive) && FileUtils::existsCaseInsensitive(imgPath)) {
ClipboardUtils::setLocalFileToClipboard(clipboard, imgPath, QClipboard::Clipboard);
return ;
}

auto img = FileUtils::imageFromFile(imgPath);
if (!img.isNull()) {
ClipboardUtils::setImageToClipboard(clipboard, img);
Expand Down
Loading