Refs #54, #55 -- check payload type before trimming #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 10 10
Lines 368 370 +2
=======================================
+ Hits 367 369 +2
Misses 1 1
☔ View full report in Codecov by Sentry. |
codingjoe
reviewed
Sep 25, 2023
codingjoe
approved these changes
Oct 20, 2023
Member
codingjoe
left a comment
There was a problem hiding this comment.
I just move two lines for better performance and renamed an import that caught my attention during the review.
Member
Author
lol, makes total sense, thanks, Johannes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.