Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@amureki
Copy link
Member

@amureki amureki commented Aug 14, 2024

Introducing a way to access a dashboard with all available email classes used in the project.

  • /emark/dashboard/ allows to see the list of emails
  • /emark/dashboard/<str:email_class>/ gets to the raw email preview without any values filled
  • A new setting EMARK.DASHBOARD_HIDDEN_CLASSES allows to exclude certain classes (for example abstract base classes) from the dashboard

@amureki amureki self-assigned this Aug 14, 2024
@amureki amureki force-pushed the preview-dashboard branch from 4132446 to b9762ce Compare August 14, 2024 14:54
@amureki amureki changed the title Add dashboard with emails preview Add a dashboard with email previews Aug 14, 2024
@amureki amureki requested a review from codingjoe September 24, 2024 15:11
Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I amended a little rewrite. Someone else needs to review this again.

Copy link
Contributor

@herrbenesch herrbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Really like the concept.
It's already a win to have a list of registered emails.
The rendered email itself does currently only provide a small improvement from just looking at the code. Especially given the following use cases:

  1. As a dev, I want a preview of email changes without the need to send one to myself
  2. As an email marketing person, I want to see the rendered emails as if they were sent to me directly.

IMHO This feature would be more useful if it rendered out the html. At least the include statements should be resolved.
Also we allow to mix html and markdown formatting which leads to broken looking email previews since only the markdown is rendered.
I'm ok with treating this as a preview feature. Rendered HTML would be actually useful though.

Copy link
Contributor

@herrbenesch herrbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still find this more useful if somehow the html was rendered. A very good start though.

@codingjoe codingjoe merged commit 62d8b87 into main Sep 27, 2024
@codingjoe codingjoe deleted the preview-dashboard branch September 27, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants