Ballot comparison: Fix ES&S overvotes getting always flagged as discrepancies #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ballot comparison audits
Contributor
|
While I was reloading context to review this PR, I tried out a different solution that is based on the audit math itself, let me know what you think: #2162 |
Contributor
Author
|
Pausing for now per #2100 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2099
Addresses a longstanding ballot comparison bug where reported ES&S overvotes are always flagged as discrepancies, even when the audit confirms an overvote. This PR addresses that and records no discrepancy when both the ES&S CVR and audit record an overvote.
Sought inspiration from #2100 but made an adjustment to correct what I believe is a bug in that implementation (#2100 (comment)), unless my understanding of ES&S CVRs is incorrect!