feat: correct converted rows when OCI_DPR_FULL occurs #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time the function
OCI_DirPathConvertis called,dp->nb_currows would be converted, seesdirpath.c:1060-->dirpath.c:39in functionOcilibDirPathSetArray:the final numer connverted in a round shall be doubled:
So resetting dp->nb_cur is needed to ensure that there would be exactly nb_rows being converted in a round:
Consequently, it's also needed that resetting dp->nb_cur to dp->nb_rows every time
OcilibDirPathResetis called:I have verified this fixing in production, wish you accept it. ^_^