-
-
Notifications
You must be signed in to change notification settings - Fork 12
Testing stream and capture of output #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…if executable not found Signed-off-by: Vanessa Sochat <[email protected]>
Signed-off-by: Vanessa Sochat <[email protected]>
|
Whoa, you are amazing! So, I tried your branch by adding this to my Dockerfile instead of "RUN pip install scif": It seemed to do the install, but then freaked out on my scif recipes (which were behaving last night). I'll upload the whole log, but things aren't interesting, I think, until about line 485. |
|
You need to use Python 3.x version - at this point (since Python 2 end of life is ~2 months) you shouldn't be developing with Python 2, really ever. |
|
I can try using |
|
Here is how it works: Here is your error Here is the workaround >>> from __future__ import print_function
>>> print("test", end="\n")
testGive me a few minutes to update the PR. |
Signed-off-by: Vanessa Sochat <[email protected]>
|
-> 19b6605 |
|
Gosh, this is news to me. I install Python3 in the Dockerfile...I guess, since it is based on Ubuntu Trusty, it must be using Python2 by default, even though I installed Python 3? Thanks for identifying that issue. I'll try to make improvements on my end. |
|
Yes that's exactly true - the "python" executable maps to python 2, and python3 to python 3. Here is a quick example: I think when you install |
|
I'm with you: Now I'll try with your streaming version. |
|
Okay, your streaming version builds now...AND, it is streaming output right to my screen as it runs!! -Dianne |
|
Awesome! I'm going to merge now (so you could install from master branch) but will wait to release on pypi as 0.0.78 until the conda recipe is merged conda-forge/staged-recipes#9853 that way the release will trigger a conda build. |
And fixing bug that we should not run a command if the executable is not found. This pull request can be tested either locally or with a container.
Locally
First remove all installations of scif:
do that command until it tells you it isn't installed. Then clone the branch here:
$ git clone -b test/stream-capture-output https://www.github.com/vsoch/scif cd scif python setup.py installAnd test as you need!
Container Test
if you want to test with a container, I've pushed the tag
0.0.78-rcto quay.ioAnd you can use this container as a base for your own scif recipe, or any of the tutorials or examples.
Signed-off-by: Vanessa Sochat [email protected]