-
Notifications
You must be signed in to change notification settings - Fork 11
Require sticky activation to perform vibrate #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also: - Add dfns: this, relevant global object, sticky activation - Remove unused refs: spin the event loop, Navigator - Link to the "user agent" dfn (Future work: refactor to use the fancier ref syntax.) Fix #29
PTAL @johannhof Also, PR Preview integration seems to have a bad day today (Internal Server Error), FYI @xfq |
It's tracked in tobie/pr-preview#124 |
Also use new method steps prose for vibrate()
This is clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for making the adjustments!
Re-requesting @rakuco in an attempt to unblock merge. |
It still says At least 1 approving review is required by reviewers with write access here. |
@xfq can you please fix access for @rakuco? As a spin-off, I’m considering a @xfq are GH permissions for W3C repos best practices documented somewhere? https://w3c.github.io/best-practices.html#perms is generic. |
Apologies, I keep being a bit late on your requests but it looks like @rakuco covered it well. No other comments from me :) Thanks! |
Sorry, not currently available as far as I know. Feel free to file an issue in https://github.com/w3c/w3c.github.io/issues if you have any proposal. |
Thanks @rakuco and @johannhof for your review, and @xfq for the GH permissions fix. |
Also:
(Future work: refactor to use the fancier ref syntax.)
Fix #29
Preview | Diff