Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented May 25, 2022

Also:

  • Add dfns: this, relevant global object, sticky activation
  • Remove unused refs: spin the event loop, Navigator
  • Link to the "user agent" dfn

(Future work: refactor to use the fancier ref syntax.)

Fix #29


Preview | Diff

Also:
- Add dfns: this, relevant global object, sticky activation
- Remove unused refs: spin the event loop, Navigator
- Link to the "user agent" dfn

(Future work: refactor to use the fancier ref syntax.)

Fix #29
@anssiko anssiko requested a review from rakuco May 25, 2022 11:37
@anssiko
Copy link
Member Author

anssiko commented May 25, 2022

PTAL @johannhof

Also, PR Preview integration seems to have a bad day today (Internal Server Error), FYI @xfq

@xfq
Copy link
Member

xfq commented May 26, 2022

Also, PR Preview integration seems to have a bad day today (Internal Server Error), FYI @xfq

It's tracked in tobie/pr-preview#124

Copy link
Member

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for making the adjustments!

@anssiko
Copy link
Member Author

anssiko commented May 30, 2022

Re-requesting @rakuco in an attempt to unblock merge.

@anssiko anssiko requested a review from rakuco May 30, 2022 19:33
@rakuco
Copy link
Member

rakuco commented May 30, 2022

It still says At least 1 approving review is required by reviewers with write access here.

@anssiko
Copy link
Member Author

anssiko commented May 31, 2022

@xfq can you please fix access for @rakuco?

As a spin-off, I’m considering a das-wg-reviewers GH team for known folks for WG-wide reviews, WDYT @reillyeon?

@xfq are GH permissions for W3C repos best practices documented somewhere? https://w3c.github.io/best-practices.html#perms is generic.

@johannhof
Copy link
Member

PTAL @johannhof

Apologies, I keep being a bit late on your requests but it looks like @rakuco covered it well. No other comments from me :)

Thanks!

@xfq
Copy link
Member

xfq commented Jun 1, 2022

@xfq can you please fix access for @rakuco?

Done.

@xfq
Copy link
Member

xfq commented Jun 1, 2022

@xfq are GH permissions for W3C repos best practices documented somewhere? https://w3c.github.io/best-practices.html#perms is generic.

Sorry, not currently available as far as I know. Feel free to file an issue in https://github.com/w3c/w3c.github.io/issues if you have any proposal.

@anssiko
Copy link
Member Author

anssiko commented Jun 1, 2022

Thanks @rakuco and @johannhof for your review, and @xfq for the GH permissions fix.

@anssiko anssiko merged commit 26a6ac0 into gh-pages Jun 1, 2022
@anssiko anssiko deleted the sticky-activation branch June 1, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require user activation for navigator.vibrate

5 participants