Add and link attribute terms: Defines, Identifies, and Indicates. #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confession: I found it somewhat challenging to define the terms Defines, Identifies, and Indicates, without using those words in the definitions. ;-) I went with "denote" but I'm very open to nitpick changes if a better term is suggested. |
jnurthen
approved these changes
Mar 25, 2021
carmacleod
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Looks good! "Denote" works for me. :)
I had one nit for "type is of type" in Defines.
Regarding the XML Schema terms vs. the ARIA Characteristics Table type terms, I'll leave that up to you.
cookiecrook
commented
Apr 2, 2021
cookiecrook
commented
Apr 2, 2021
|
@carmacleod I think all your requested changes are incorporated now. Please verify and thanks. |
carmacleod
approved these changes
Apr 2, 2021
Accepting CM’s redundancy correction. Co-authored-by: Carolyn MacLeod <[email protected]>
Closed
jnurthen
added a commit
that referenced
this pull request
Jun 2, 2022
) * Add and link attribute terms: Defines, Identifies, and Indicates. Resolves #516. Co-authored-by: Carolyn MacLeod <[email protected]> Co-authored-by: James Nurthen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and link attribute terms: Defines, Identifies, and Indicates. Resolves #516.
Preview | Diff