-
Notifications
You must be signed in to change notification settings - Fork 136
Update paragraph in option to remove DOM focus requirement #1682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@carmacleod If I understand correctly, you have removed the variant that the list entry (role=option) has DOM focus. I think that is wrong. Our discussion was about what happens if the option does not have DOM focus. But with DOM focus, the option should also be considered selected (aria-selected=true), regardless of the tabindex. In practice, DOM focus and tabindex will usually coincide, but this does not necessarily have to be the case. My suggestion would be to reinsert "has DOM focus or". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think more work is need to avoid hidden or inert elements that still match this criteria... It may be as simple as adding, "…and are not hidden or inert…" but I'm not in a position to consider prose suggestions deeply at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Darn I have to say I'm not a huge fan of leaving "has dom focus" in this list, @JAWS-test -- what scenario satisfies "has dom focus" while not satisfying something else from the list? Happy to be convinced otherwise but it seems unnecessary to add.
Otherwise I'm good with the change just waiting to leave a +1 until I understand :)
Two reasons for leaving "has dom focus":
But I don't mind if dom focus is removed either. In the end it's just about providing a repair mechanism when no aria-selected is used |
@cookiecrook question b/c I have no idea how this is implemented in browsers -- how important is it to specify that hidden/inert options are not implicitly selected if they aren't exposed anyway? Just from an authoring standpoint, I don't think I would care about that detail unless future AOM stuff makes it possible to somehow query the implicit selection of an ARIA listbox. I do agree with @JAWS-test that disabled options should not get implicit selection no matter what. |
what happens if all options are set to tabindex 0+? everything is selected? that seems wrong.... but also, trying to guess at which is the correct selection is more wrong. |
Closing this PR, since #1719 was merged |
Fixes #1661
Preview | Diff