Conversation
this pr updates `aria-details` to mention `figure` and `figcaption`. This update is related to HTML AAM's update to the `figure` and `figcaption` elements - w3c/html-aam#359. It is a follow on to my other PR, #1703 which updates the `caption` role and includes information about `aria-details`.
7 tasks
chlane
approved these changes
Mar 31, 2022
Contributor
chlane
left a comment
There was a problem hiding this comment.
I agree with aria-details referencing captions
charmarkk
requested changes
Mar 31, 2022
Contributor
charmarkk
left a comment
There was a problem hiding this comment.
I agree, and editorial looks good (once "within" has its H).
scottaohara
commented
Apr 1, 2022
smhigley
reviewed
Apr 1, 2022
Co-authored-by: Sarah Higley <[email protected]>
smhigley
approved these changes
Apr 1, 2022
Member
Author
|
@pkra can this be merged as well, per the other related caption PRs I made that were merged earlier today? thanks! |
jnurthen
pushed a commit
that referenced
this pull request
Oct 10, 2023
* include mention of figure/caption this pr updates `aria-details` to mention `figure` and `figcaption`. This update is related to HTML AAM's update to the `figure` and `figcaption` elements - w3c/html-aam#359. It is a follow on to my other PR, #1703 which updates the `caption` role and includes information about `aria-details`. Co-authored-by: Sarah Higley <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr updates
aria-detailsto mentionfigureandfigcaption.This update is related to HTML AAM's update to the
figureandfigcaptionelements - w3c/html-aam#359.It is a follow on to my other PR, #1703 which updates the
captionrole and includes information aboutaria-details.Preview | Diff