Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update: clarify / expand value attribute mappings #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Nov 8, 2024

replacement for w3c/html-aam#396

closes w3c/html-aam#314

This should largely be reflecting what is currently happening in browsers.


Preview | Diff

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 13a6f8b
🔍 Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/686ea92079242d0009913104
😎 Deploy Preview https://deploy-preview-2373--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with change suggestions.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this change is documenting browsers, then I think it should land!

I like Jame's suggestions and have one minor point of confusion.

@spectranaut spectranaut moved this from Needs Review to Needs updates from review in ARIA Normative PR Tracking Jul 3, 2025
@spectranaut
Copy link
Contributor

We need to fix this branch before landing, something crazy is happening.

@pkra
Copy link
Member

pkra commented Jul 9, 2025

@spectranaut this looks similar to the problem in #2235. @daniel-montalvo do you have any insights?

@daniel-montalvo
Copy link
Contributor

@spectranaut this looks similar to the problem in #2235. @daniel-montalvo do you have any insights?

@pkra @spectranaut
I merged main and pushed the changes (didn't rebase though). Now this shows only one changed file html-aam/index.html and
we have a more comprehensible diff. Is this any better?

@spectranaut
Copy link
Contributor

I think this is ready to merge @scottaohara !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs updates from review
Development

Successfully merging this pull request may close these issues.

value should map to aria-valuenow for input[type=range]
7 participants