Chore: Simplify Badging API to app-only scope #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove navigator.setClientBadge() and clearClientBadge() methods - Remove document/tab badging functionality and examples - Focus API exclusively on app badging with setAppBadge()/clearAppBadge() - Update usage examples to demonstrate app badging only - Simplify feature detection section - Remove references to dual API approach - Update design questions to reflect app-only focus
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the Badging API explainer by removing the document/tab badging functionality and focusing exclusively on app-level badging. The changes streamline the API surface from a dual API approach to a single app-only API.
- Removes all references to
setClientBadge()andclearClientBadge()methods for document badges - Updates all usage examples to demonstrate only the app badge API (
setAppBadge()andclearAppBadge()) - Simplifies feature detection and removes fallback logic for document badges
Comments suppressed due to low confidence (1)
explainer.md:416
- The section heading references
navigatorbut there's no corresponding section content explaining why the API is attached tonavigator. This creates a broken anchor link and leaves the design decision unexplained.
### Why is this API attached to `navigator` instead of `window` or `notifications`?
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
marcoscaceres
commented
Oct 2, 2025
marcoscaceres
commented
Oct 2, 2025
marcoscaceres
commented
Oct 2, 2025
4 tasks
diekus
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Explainer:
This pull request refactors the Badging API explainer to simplify the API surface, remove the document badge functionality, and clarify the API's scope and usage. The changes focus the explainer on the app badge API, update usage examples, and clean up outdated references and feature detection logic. The result is a clearer, more concise document that describes only the app-level badging API.
API Surface and Scope Simplification
setClientBadgeandclearClientBadge) and updated the explainer to describe only the app badge API (setAppBadgeandclearAppBadge). [1] [2] [3]navigator.setAppBadgeonly. [1] [2]Usage and Examples
Design and Rationale
navigatorand why a declarative approach is less suitable for the app API. [1] [2]Cleanup and Consistency
Minor Corrections
This change (choose at least one, delete ones that don't apply):