SPARQL 1.0: variable introduced by GRAPH is not affecting inner OPTIONAL #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scoping is already tested but this is an easy mistake when trying to optimize such queries
rubensworks
approved these changes
Oct 10, 2025
afs
requested changes
Oct 16, 2025
| ] ; | ||
| mf:result <graph-variable-join.ttl> ; | ||
| . | ||
| :graph-optional rdf:type mf:QueryEvaluationTest ; |
There was a problem hiding this comment.
This isn't in the list of tests at mf:entries so it does not run.
afs
requested changes
Oct 17, 2025
Comment on lines
9
to
11
| rs:binding [ rs:value <data-variable-join.ttl> ; | ||
| rs:variable "http://example/s2" | ||
| ] |
There was a problem hiding this comment.
This looks wrong. The variable is s.
I think the right answer is:
Suggested change
| rs:binding [ rs:value <data-variable-join.ttl> ; | |
| rs:variable "http://example/s2" | |
| ] | |
| rs:binding [ rs:value <data-optional.ttl> ; | |
| rs:variable "s" | |
| ] |
that is:
-----------------------------
| g | s |
============================
| <data-optional.ttl> | :s2 |
-----------------------------
There was a problem hiding this comment.
Indeed, got confused. Fixed. Thanks for spotting
afs
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scoping is already tested but this is an easy mistake when trying to optimize such queries