fix: resolve Tailwind CSS v4 hydration issues #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Tailwind CSS v4 hydration issues by updating how CSS is imported in the root component.
- Changed the CSS import from using a URL query parameter to a direct import.
- Removed the stylesheet link reference that pointed to the appStylesUrl variable.
Comments suppressed due to low confidence (2)
app/root.tsx:5
- Replacing the URL-based import with a direct CSS import can affect how the CSS file is processed by the build tool. Confirm that this change aligns with your bundler configuration to ensure correct injection and ordering of styles for hydration.
import '~/styles/app.css';
app/root.tsx:26
- Since the CSS is now imported directly, the removal of the stylesheet link in the links array is appropriate if the bundler correctly injects the styles. Verify that this change does not inadvertently omit the stylesheet in the final HTML output.
},
Owner
Author
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons I don't fully understand, Vite + Tailwind v4 generates two different CSS files in production builds, one for the client and one for the server - with different hashes in the name. This causes React hydration issues in production. Leveraging Vite's CSS side-effect imports rather than the traditional React Router "links" method resolves the issue.
¯\_(ツ)_/¯Whatever.